Address client-hints-04 feedback #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2017
Closed
mnot
approved these changes
Jun 27, 2017
|
Oh, one thing -- you removed Downlink. It'd be good to mention that in the change notes, and on list, so people are aware. |
reschke
reviewed
Jun 27, 2017
draft-ietf-httpbis-client-hints.md
Outdated
| @@ -89,7 +89,7 @@ Client Hints does not supersede or replace the User-Agent header field. Existing | |||
|
|
|||
| ## Notational Conventions | |||
|
|
|||
| The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in {{RFC2119}}. | |||
| The key words "MUST", "MUST NOT", "REQUIRED", "SHOULD", "SHOULD NOT", "MAY", and "OPTIONAL" in this document are to be interpreted as described in BCP 14 {{RFC2119}} when, and only when, they appear capitalized, as shown. | |||
There was a problem hiding this comment.
This doesn't seem to be consistent with https://tools.ietf.org/html/rfc8174#section-2
There was a problem hiding this comment.
Good catch, looks like I took the text from outdated draft.
|
Thanks guys, pushed a few more updates. @reschke everything else looks good? If so I'll squash+push a new draft. |
|
@reschke can you take another pass, please? Want to make sure we caught all of your feedback here. |
Related: #359.
Moving definition to NetInfo spec.
Also, augmented example to illustrate list behavior for Accept-CH.
|
@reschke merging. If you have any followup feedback, we can open a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #359, #360.