Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

ci: turn on some taplo rules to format Cargo.toml #262

Merged
merged 3 commits into from
Jan 7, 2022
Merged

ci: turn on some taplo rules to format Cargo.toml #262

merged 3 commits into from
Jan 7, 2022

Conversation

xxchan
Copy link

@xxchan xxchan commented Jan 6, 2022

As discussed in #181, Cargo.toml style guide is not respected. rustfmt will support it in the future.

As a temporary solution, we turn on some taplo options, including:

  • sort keys within each section (I think this is the most likely scenario)
  • array auto collapse & expand.

tisonkun
tisonkun previously approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

cc @huachaohuang

@tisonkun
Copy link
Contributor

tisonkun commented Jan 7, 2022

@xxchan one comment is that whether it's OK to close #181?

huachaohuang
huachaohuang reviewed Jan 7, 2022
View reviewed changes
Copy link
Owner

@huachaohuang huachaohuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM, thanks!

taplo.toml Outdated Show resolved Hide resolved
@xxchan @huachaohuang
Update taplo.toml
6b4b567 
Co-authored-by: Richard <huachao.huang@gmail.com>
@xxchan
Copy link
Author

xxchan commented Jan 7, 2022

@xxchan one comment is that whether it's OK to close #181?

Strictly speaking, it's not completely resolved. Personally speaking, current status is good enough and we can just close it to reduce distraction.

@huachaohuang huachaohuang merged commit f113b44 into huachaohuang:main Jan 7, 2022
@huachaohuang
Copy link
Owner

Strictly speaking, it's not completely resolved. Personally speaking, current status is good enough and we can just close it to reduce distraction.

Agree, it's good enough, let's close it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huachaohuang huachaohuang huachaohuang approved these changes

@tisonkun tisonkun tisonkun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxchan @tisonkun @huachaohuang