Added direction information to callback interfaces #5
Conversation
| @@ -35,6 +39,8 @@ | |||
| * The item being added back | |||
| * @param position | |||
| * The position of the item being added back | |||
| * @param direction | |||
There was a problem hiding this comment.
@marchy You added a new direction param while the method definition is not updated. I think there is no benefit of passing direction when an item is added back to the list, so probably no change should be made here. What do you think?
There was a problem hiding this comment.
Hey @huan-nguyen this was a miss on my part. The direction info would be needed for an undo to be able to know which action was taken and thus how to undo that action.
I've added this parameter & associated data in and re-submitted 👍🏻
|
Hi @marchy, also thanks for this PR. Appreciate it! |
marchy
force-pushed
the
feature/callbacks
branch
from
bd253f1 to
ac38310
Compare
|
My pleasure @huan-nguyen, and apologies for the slowness. I've amended the commit, please have a look again and see if the PR is acceptable. |
marchy
force-pushed
the
feature/callbacks
branch
from
ff40767 to
22fbe7e
Compare
marchy
force-pushed
the
feature/callbacks
branch
from
22fbe7e to
6a2ff1a
Compare
|
Hey @huan-nguyen could you review & accept this when you get a chance? |
Added the direction information to all callback interfaces so that you can perform the appropriate logic based on what the left/right swipe action is