Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove experimental.legacyExternals #104

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

huang-julien
Copy link
Owner

@huang-julien huang-julien commented Sep 30, 2024

fix #59

This PR removes usage of experimental.legacyExternals. experimental.legacyExternals is starting to cause issues with some modules such as @nuxt/icon when enabled.

it:

  • remove the flag
  • move setup.ts into plugin.ts
  • create an applicationinsights file
  • create an alias to our applicationinsights file.

With this fix, users won't have to set the resolution of mlly to 1.4.0 anymore

@huang-julien huang-julien merged commit c129045 into main Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inline applicationinsights as ESM module
1 participant