Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature bubble conditions #2020

Merged
merged 8 commits into from
May 25, 2023
Merged

Feature bubble conditions #2020

merged 8 commits into from
May 25, 2023

Conversation

Gamenot
Copy link
Collaborator

@Gamenot Gamenot commented May 11, 2023

This PR extends #1965 to add conditions to bubbles

After some discussion, we decided that the bubble airlock should be what accepts or rejects actors. This means:

  • A vehicle must be accepted by the airlock to be considered in the bubble.
  • On the step that the bubble agent takes over the vehicle the vehicle must still be in the bubble.
  • Once the bubble controls the vehicle, the airlock condition should no longer apply due to issues caused by continuing the selection by airlock condition.
    • Note the following problem case:
      • The intention is to get a parked vehicle and have the bubble agent intercept a vehicle that is driving by.
      • The airlock condition filters for parked vehicles.
      • The airlock condition accepts the parked bike.
      • The airlock condition still accepts the parked bike and lets it into the bubble.
      • The agent moves the bike.
      • The airlock condition rejects the now moving bike causing the bike to drop out of the bubble.
    • If the agent has the intention of moving then the bubble conditions get in the way of that intention.
  • Whether we should have bubble residency conditions may be discussed.

Closes #2002

@Gamenot Gamenot self-assigned this May 11, 2023
@Gamenot Gamenot force-pushed the tucker/feature-bubble-conditions branch 5 times, most recently from 6a70eb7 to 2e3b2dd Compare May 12, 2023 21:31
Base automatically changed from tucker/add-sstudio_conditions to master May 17, 2023 14:43
@Gamenot Gamenot force-pushed the tucker/feature-bubble-conditions branch from 2e3b2dd to a71306c Compare May 18, 2023 15:26
@Gamenot Gamenot merged commit afb84d0 into master May 25, 2023
@Gamenot Gamenot deleted the tucker/feature-bubble-conditions branch May 25, 2023 21:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Conditional vehicle takeover
3 participants