Universal DistToDestination metric #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamenot
approved these changes
May 29, 2023
Comment on lines
+641
to
+642
| "Route computed in reverse direction from point_b to " | ||
| f"point_a resulting in negative distance: {dist_tot}." |
There was a problem hiding this comment.
Perhaps we should be using the term displacement rather than distance here since distance can also mean magnitude from a point.
There was a problem hiding this comment.
If the route from point_b to point_a is not straight, then the route distance will be longer than the displacement between point_b and point_a. So rephrasing the error message as "Route computed in reverse direction from point_b to point_a resulting in negative displacement: {dist_tot}." also sounds a little awkward as the displacement might be shorter than the printed dist_tot.
saulfield
approved these changes
May 30, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DistToDestinationmetric is now computed by summing the(i) off-route distance driven by the vehicle from its last on-route position, and
(ii) the distance to goal from the vehicle's last on-route position.