Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gym dependency #2074

Merged
merged 9 commits into from
Jul 4, 2023
Merged

Remove gym dependency #2074

merged 9 commits into from
Jul 4, 2023

Conversation

saulfield
Copy link
Contributor

@saulfield saulfield commented Jun 29, 2023

More progress towards #1981.

  • Fix make test
  • Change all remaining references of gym to gymnasium
  • Remove hiway-v0 env
  • Remove gym v21 compatibility wrapper
  • Remove gym dependency
  • Made gymnasium dependency optional

@saulfield
Copy link
Contributor Author

All the examples appear to be working with gymnasium aside from drive and platoon. There appears to be an issue with stable_baselines3 (see the failing CI test). I tried using v2.0.0 which added support for gymnasium, but the error is still happening. I've made this a draft PR since I think we should just do this all in one go, instead of leaving gym as a dependency for the rl examples, which would require some additional code changes.

@Adaickalavan
Copy link
Member

PR #2075 updates the drive and platoon examples to use Stable Baselines3 v2.0.0 and gymnasium.

@saulfield saulfield marked this pull request as ready for review June 30, 2023 17:22
setup.cfg Outdated
rllib =
opencv-python==4.1.2.30
opencv-python-headless==4.1.2.30
ray[rllib]~=2.5.0
tensorflow-probability
tensorflow>=2.12.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember adding it to get a test to pass. I'll try removing it.

@saulfield saulfield merged commit 4b89cd0 into master Jul 4, 2023
@saulfield saulfield deleted the saul/remove-gym branch July 4, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants