Allow random routes to vary across traffic groups. #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarts/sstudio/genscenario.py
Outdated
| @@ -243,11 +246,12 @@ def gen_scenario( | |||
| ): | |||
| with timeit("traffic", logger.info): | |||
| for name, traffic in scenario.traffic.items(): | |||
| derived_seed = random.randint(-0b111111111111111, 0b111111111111111) | |||
There was a problem hiding this comment.
- Does the use of
random.randint()here have any determinism issues between diferent runs? - If different seeds are required, can we fix them as
derived_seed = global_seed + loop_iteration_number? - Instead of binary inputs to
random.randint(), consider using integer inputs.
There was a problem hiding this comment.
random.randint()does not cause determinism issues because it is pseudo-random.- That could also work.
- If I take suggestion 2 this point would be already handled.
Adaickalavan
approved these changes
Nov 16, 2023
| gen_traffic( | ||
| scenario=scenario_dir, | ||
| traffic=traffic, | ||
| name=name, | ||
| seed=seed, | ||
| seed=derived_seed, |
There was a problem hiding this comment.
Perhaps we should wrap the seed here (at the point where it is introduced) instead of later where it is used in generator.plan_and_save().
There was a problem hiding this comment.
I disagree, if we wrap over the integer at this level then the implementation will affect how we use this method. Which is a big no in my opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2108