Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dws): fix some resources cannot trigger the check checkdeleted logic #5395

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

wuzhuanhong
Copy link
Contributor

@wuzhuanhong wuzhuanhong commented Aug 14, 2024

What this PR does / why we need it:

Fix the issue that the checkdeleted logic cannot be triggered for cluster/ext_data_source/snapshot_policy/logical_cluster resources.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccSomethingV0_basic'
...
make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccResourceCluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccResourceCluster_basic -timeout 360m -parallel 4
=== RUN   TestAccResourceCluster_basicV1
=== PAUSE TestAccResourceCluster_basicV1
=== RUN   TestAccResourceCluster_basicV2
=== PAUSE TestAccResourceCluster_basicV2
=== CONT  TestAccResourceCluster_basicV1
=== CONT  TestAccResourceCluster_basicV2
--- PASS: TestAccResourceCluster_basicV1 (2418.03s)
--- PASS: TestAccResourceCluster_basicV2 (2720.85s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       2720.910s

make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccDwsExtDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccDwsExtDataSource_basic -timeout 360m -parallel 4
=== RUN   TestAccDwsExtDataSource_basic
=== PAUSE TestAccDwsExtDataSource_basic
=== CONT  TestAccDwsExtDataSource_basic
--- PASS: TestAccDwsExtDataSource_basic (1546.96s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       1547.013s

make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccDwsSnapshotPolicy_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccDwsSnapshotPolicy_basic -timeout 360m -parallel 4
=== RUN   TestAccDwsSnapshotPolicy_basic
=== PAUSE TestAccDwsSnapshotPolicy_basic
=== CONT  TestAccDwsSnapshotPolicy_basic
--- PASS: TestAccDwsSnapshotPolicy_basic (1369.31s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       1369.409s

make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccLogicalCluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccLogicalCluster_basic -timeout 360m -parallel 4
=== RUN   TestAccLogicalCluster_basic
=== PAUSE TestAccLogicalCluster_basic
=== CONT  TestAccLogicalCluster_basic
--- PASS: TestAccLogicalCluster_basic (1934.94s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       1935.000s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      huaweicloud_dws_cluster
      Resource not found(the cluster was deleted after it was created. Status code is 404)
      image

      Resource not found (cluster ID is standard UUID)
      image

      Resource not found (cluster ID is non-standard UUID)
      image

    huaweicloud_dws_ext_data_source
    Resource not found
    image

    Related resources (cluster ID is standard UUID) not found
    image

    Related resources (cluster ID is non-standard UUID) not found
    image

    huaweicloud_dws_snapshot_policy
    Resource not found
    image

    Related resources (cluster ID is standard UUID) not found
    image

    Related resources (cluster ID is non-standard UUID) not found
    image

    huaweicloud_dws_logical_cluster
    Resource not found
    image

    Resource not found (cluster ID is standard UUID)
    image

    Resource not found (cluster ID is non-standard UUID)
    image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@wuzhuanhong wuzhuanhong force-pushed the dws_checkdeleted branch 2 times, most recently from e94ac22 to f72aaf1 Compare August 15, 2024 06:17
@wuzhuanhong wuzhuanhong changed the title fix(dws): fix checkdeleted for cluster/ext_data_source/snapshot_policy fix(dws): fix some resources cannot trigger the check checkdeleted logic Aug 15, 2024
@wuzhuanhong wuzhuanhong force-pushed the dws_checkdeleted branch 3 times, most recently from 8af304c to df0d38b Compare August 19, 2024 12:15
@Lance52259
Copy link
Collaborator

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 0f3220d into huaweicloud:master Aug 26, 2024
11 checks passed
@wuzhuanhong wuzhuanhong deleted the dws_checkdeleted branch September 5, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugfix LGTM /lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants