Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dws): fix some issues for cluster and logical cluster #5415

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

wuzhuanhong
Copy link
Contributor

@wuzhuanhong wuzhuanhong commented Aug 19, 2024

What this PR does / why we need it:

  • huaweicloud_dws_cluster

    • Modify the version parameter document link.
    • Change the volume parameter from required to optional.
  • huaweicloud_dws_logical_cluster

    • Fix the error 417 when creating logical clusters in parallel (Multiple logical clusters cannot be created at the same time for the same DWS cluster. The previous logical cluster must be successfully created before the next logical cluster can be created).
    • Fix the timeout error when deleting the last logical cluster(For versions after 820, the last logical cluster cannot be deleted. delete_enable and first_logical_cluster are both false).
  • Remove the CheckDeleted logical of the data sources.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
$ make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccLogicalCluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccLogicalCluster_basic -timeout 360m -parallel 4
=== RUN   TestAccLogicalCluster_basic
=== PAUSE TestAccLogicalCluster_basic
=== CONT  TestAccLogicalCluster_basic
--- PASS: TestAccLogicalCluster_basic (1922.70s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       1922.785s

make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccResourceCluster_basicV2_mutilAZs'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccResourceCluster_basicV2_mutilAZs -timeout 360m -parallel 4
=== RUN   TestAccResourceCluster_basicV2_mutilAZs
=== PAUSE TestAccResourceCluster_basicV2_mutilAZs
=== CONT  TestAccResourceCluster_basicV2_mutilAZs
--- PASS: TestAccResourceCluster_basicV2_mutilAZs (1657.50s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       1657.559s

make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccLogicalCluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccLogicalCluster_basic -timeout 360m -parallel 4
=== RUN   TestAccLogicalCluster_basic
=== PAUSE TestAccLogicalCluster_basic
=== CONT  TestAccLogicalCluster_basic
--- PASS: TestAccLogicalCluster_basic (2046.23s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       2046.414s

 make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccDisasterRecoveryTasksDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccDisasterRecoveryTasksDataSource_basic -timeout 360m -parallel 4
=== RUN   TestAccDisasterRecoveryTasksDataSource_basic
=== PAUSE TestAccDisasterRecoveryTasksDataSource_basic
=== CONT  TestAccDisasterRecoveryTasksDataSource_basic
--- PASS: TestAccDisasterRecoveryTasksDataSource_basic (81.59s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       81.648s

 make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccEventSubscriptionsDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccEventSubscriptionsDataSource_basic -timeout 360m -parallel 4
=== RUN   TestAccEventSubscriptionsDataSource_basic
=== PAUSE TestAccEventSubscriptionsDataSource_basic
=== CONT  TestAccEventSubscriptionsDataSource_basic
--- PASS: TestAccEventSubscriptionsDataSource_basic (85.14s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       85.257s

make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccDwsFlavorsDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccDwsFlavorsDataSource_basic -timeout 360m -parallel 4
=== RUN   TestAccDwsFlavorsDataSource_basic
=== PAUSE TestAccDwsFlavorsDataSource_basic
=== CONT  TestAccDwsFlavorsDataSource_basic
--- PASS: TestAccDwsFlavorsDataSource_basic (31.78s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       31.842s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-actions github-actions bot added the chore label Aug 20, 2024
@github-actions github-actions bot added size/M and removed size/S labels Aug 20, 2024
@Lance52259
Copy link
Collaborator

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 1e81357 into huaweicloud:master Aug 26, 2024
14 checks passed
@wuzhuanhong wuzhuanhong deleted the fix_dws_issue branch September 5, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugfix chore LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants