Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dws): supports updating eip_id for the cluster #5442

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:

  1. The cluster resource supports updating the EIP ID.
  2. Adjust the corresponding acceptance tests.
  3. Remove the Computed of the tags parameter.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
./scripts/acc-test.sh
>>> Start to test
=== RUN   TestAccResourceCluster_basicV1
=== PAUSE TestAccResourceCluster_basicV1
=== RUN   TestAccResourceCluster_basicV2
=== PAUSE TestAccResourceCluster_basicV2
=== RUN   TestAccResourceCluster_basicV2_mutilAZs
=== PAUSE TestAccResourceCluster_basicV2_mutilAZs
=== CONT  TestAccResourceCluster_basicV1
=== CONT  TestAccResourceCluster_basicV2_mutilAZs
=== CONT  TestAccResourceCluster_basicV2
=== CONT  TestAccResourceCluster_basicV2_mutilAZs
    acceptance.go:1928: HW_DWS_MUTIL_AZS must be set for the acceptance test
--- SKIP: TestAccResourceCluster_basicV2_mutilAZs (0.00s)
--- PASS: TestAccResourceCluster_basicV1 (2577.02s)
--- PASS: TestAccResourceCluster_basicV2 (3195.93s)
PASS
coverage: 18.9% of statements in ../../dws
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       3196.003s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@wuzhuanhong
Copy link
Contributor Author

make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccResourceCluster_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccResourceCluster_ -timeout 360m -parallel 4
=== RUN TestAccResourceCluster_basicV1
=== PAUSE TestAccResourceCluster_basicV1
=== RUN TestAccResourceCluster_basicV2
=== PAUSE TestAccResourceCluster_basicV2
=== RUN TestAccResourceCluster_basicV2_mutilAZs
=== PAUSE TestAccResourceCluster_basicV2_mutilAZs
=== CONT TestAccResourceCluster_basicV1
=== CONT TestAccResourceCluster_basicV2_mutilAZs
=== CONT TestAccResourceCluster_basicV2
--- PASS: TestAccResourceCluster_basicV2_mutilAZs (1486.74s)
--- PASS: TestAccResourceCluster_basicV1 (2772.40s)
--- PASS: TestAccResourceCluster_basicV2 (3430.20s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws 3430.259s

@Lance52259
Copy link
Collaborator

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 28, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit eec6192 into huaweicloud:master Aug 28, 2024
11 checks passed
@wuzhuanhong wuzhuanhong deleted the update_dws_eip branch September 5, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chore feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants