Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CCM): refactor CCM certificate push resource #5445

Merged

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Aug 23, 2024

What this PR does / why we need it:

refactor CCM certificate push resource.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
go test -v -coverprofile=coverage_1724407894813_TestAccCcmCertificatePush_.cov -coverpkg=./huaweicloud/services/ccm ./huaweicloud/services/acceptance/ccm -run TestAccCcmCertificatePush_ -timeout 360m -parallel 4
=== RUN   TestAccCcmCertificatePush_elb
=== PAUSE TestAccCcmCertificatePush_elb
=== RUN   TestAccCcmCertificatePush_waf
=== PAUSE TestAccCcmCertificatePush_waf
=== CONT  TestAccCcmCertificatePush_elb
=== CONT  TestAccCcmCertificatePush_waf
--- PASS: TestAccCcmCertificatePush_waf (26.51s)
--- PASS: TestAccCcmCertificatePush_elb (59.30s)
PASS
coverage: 14.8% of statements in ./huaweicloud/services/ccm
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ccm       59.362s coverage: 14.8% of statements in ./huaweicloud/services/ccm
root@ecs-luxiaohang:/mnt/d/Project/Golang/terraform-provider-huaweicloud# go tool cover -html=coverage_1724407894813_TestAccCcmCertificatePush_.cov -o coverage_1724407894813_TestAccCcmCertificatePush_.cov.html

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image
      ab. Related resources (parent resources) not found
      >>>>>> Paste the screenshot here <<<<<<
      -->

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2024
@deer-hang deer-hang force-pushed the refactor-ccm-certificate-push branch from 8f9d67d to 5eadf75 Compare August 23, 2024 09:46
@deer-hang deer-hang force-pushed the refactor-ccm-certificate-push branch 2 times, most recently from c4d1ec4 to 09fe450 Compare August 23, 2024 10:04
@deer-hang deer-hang force-pushed the refactor-ccm-certificate-push branch from 09fe450 to 1e99f4f Compare August 26, 2024 08:17
@deer-hang
Copy link
Contributor Author

make testacc TEST='./huaweicloud/services/acceptance/ccm' TESTARGS='-run TestAccCcmCertificatePush_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/ccm -v -run TestAccCcmCertificatePush_ -timeout 360m -parallel 4
=== RUN   TestAccCcmCertificatePush_elb
=== PAUSE TestAccCcmCertificatePush_elb
=== RUN   TestAccCcmCertificatePush_waf
=== PAUSE TestAccCcmCertificatePush_waf
=== CONT  TestAccCcmCertificatePush_elb
=== CONT  TestAccCcmCertificatePush_waf
--- PASS: TestAccCcmCertificatePush_waf (25.77s)
--- PASS: TestAccCcmCertificatePush_elb (59.57s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ccm       59.622s

@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Aug 26, 2024
@github-ci-robot github-ci-robot merged commit d287d2d into huaweicloud:master Aug 26, 2024
13 checks passed
@deer-hang deer-hang deleted the refactor-ccm-certificate-push branch August 26, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chore LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants