feat(eg/source): add a new data source to query all kinds of the event sources #5446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This PR has been approved by: @Lance52259 |
Lance52259
changed the title
Lance52259
force-pushed
the
br_eg_event_sources_query
branch
from
6009e76
to
f15f9ff
Compare
deer-hang
reviewed
Aug 31, 2024
| * `region` - (Optional, String) Specifies the region where the event sources are located. | ||
| If omitted, the provider-level region will be used. | ||
|
|
||
| * `provider_type` - (Optional, String) Specifies the type of the event sources to be queried. |
There was a problem hiding this comment.
Please list the enumeration values for this field.
There was a problem hiding this comment.
all enums are supported.
deer-hang
reviewed
Aug 31, 2024
|
|
||
| * `description` - The description of the event source. | ||
|
|
||
| * `status` - The status of the event source. |
There was a problem hiding this comment.
Please list the enumeration values for this field.
deer-hang
reviewed
Aug 31, 2024
| %[1]s | ||
|
|
||
| resource "huaweicloud_eg_custom_event_source" "test" { | ||
| channel_id = huaweicloud_eg_custom_event_channel.test.id |
There was a problem hiding this comment.
Suggested change
| channel_id = huaweicloud_eg_custom_event_channel.test.id | |
| channel_id = huaweicloud_eg_custom_event_channel.test.id |
Aligning fields of scripts.
Same to line 161
Lance52259
force-pushed
the
br_eg_event_sources_query
branch
from
f15f9ff
to
620a979
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a new data source to query all kinds of the event sources.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
>>>>>> Paste the screenshot here <<<<<<
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found
>>>>>> Paste the screenshot here <<<<<<