feat(CES): add resource CES dashboard widget #5447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profoundwu
force-pushed
the
ces_widget
branch
4 times, most recently
from
89d11f5
to
0befb62
Compare
saf3dfsa
reviewed
Aug 26, 2024
huaweicloud/services/ces/resource_huaweicloud_ces_dashboard_widget.go
Outdated
Show resolved
Hide resolved
Comment on lines
248
to
256
| if _, ok := d.GetOk("unit"); ok { | ||
| updateWidgetPath := createWidgetClient.Endpoint + "v2/{project_id}/widgets/batch-update" | ||
| updateWidgetPath = strings.ReplaceAll(updateWidgetPath, "{project_id}", createWidgetClient.ProjectID) | ||
| updateWidgetOpt := golangsdk.RequestOpts{ | ||
| KeepResponseBody: true, | ||
| MoreHeaders: map[string]string{"Content-Type": "application/json;charset=UTF-8"}, | ||
| } | ||
| param := map[string]interface{}{ | ||
| "widget_id": d.Id(), | ||
| "unit": d.Get("unit"), | ||
| } |
There was a problem hiding this comment.
how about this, no need to get again.
Suggested change
| if _, ok := d.GetOk("unit"); ok { | |
| updateWidgetPath := createWidgetClient.Endpoint + "v2/{project_id}/widgets/batch-update" | |
| updateWidgetPath = strings.ReplaceAll(updateWidgetPath, "{project_id}", createWidgetClient.ProjectID) | |
| updateWidgetOpt := golangsdk.RequestOpts{ | |
| KeepResponseBody: true, | |
| MoreHeaders: map[string]string{"Content-Type": "application/json;charset=UTF-8"}, | |
| } | |
| param := map[string]interface{}{ | |
| "widget_id": d.Id(), | |
| "unit": d.Get("unit"), | |
| } | |
| if v, ok := d.GetOk("unit"); ok { | |
| updateWidgetPath := createWidgetClient.Endpoint + "v2/{project_id}/widgets/batch-update" | |
| updateWidgetPath = strings.ReplaceAll(updateWidgetPath, "{project_id}", createWidgetClient.ProjectID) | |
| updateWidgetOpt := golangsdk.RequestOpts{ | |
| KeepResponseBody: true, | |
| MoreHeaders: map[string]string{"Content-Type": "application/json;charset=UTF-8"}, | |
| } | |
| param := map[string]interface{}{ | |
| "widget_id": d.Id(), | |
| "unit": v, | |
| } |
|
/approve |
github-ci-robot
added
the
approved
github-ci-robot
approved these changes
Aug 26, 2024
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add resource CES dashboard widget
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
ab. Related resources (parent resources) not found
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found
bb. Related resources (parent resources) not found
