-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin 2.x release train #1860
Closed
Closed
Begin 2.x release train #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove many but not all deprecated classes and methods * Fix CI failures
Remove Java 8 and URLConnection support
Remove Previews
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
============================================
+ Coverage 81.36% 81.74% +0.37%
+ Complexity 2465 2303 -162
============================================
Files 239 231 -8
Lines 7475 6967 -508
Branches 402 376 -26
============================================
- Hits 6082 5695 -387
+ Misses 1146 1038 -108
+ Partials 247 234 -13 ☔ View full report in Codecov by Sentry. |
bitwiseman
force-pushed
the
main-2.x
branch
from
September 14, 2024 01:03
71984a1
to
a59f9af
Compare
bitwiseman
force-pushed
the
main-2.x
branch
from
September 14, 2024 01:11
a59f9af
to
d9019e0
Compare
bitwiseman
commented
Sep 14, 2024
bitwiseman
commented
Sep 14, 2024
bitwiseman
commented
Sep 14, 2024
bitwiseman
force-pushed
the
main-2.x
branch
from
September 14, 2024 08:12
06bf8a2
to
2397b07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would love for
github-api
v2.x to be a larger change that has major new features.However, the most pressing need is clearing technical debt for better stability and ease of adding new features. These changes break binary compatibility requiring a major version bump.
v2.0 includes:
HttpURLConnection
Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: