Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin 2.x release train #1860

Closed
wants to merge 41 commits into from
Closed

Begin 2.x release train #1860

wants to merge 41 commits into from

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented Jun 22, 2024

Description

I would love for github-api v2.x to be a larger change that has major new features.

However, the most pressing need is clearing technical debt for better stability and ease of adding new features. These changes break binary compatibility requiring a major version bump.

v2.0 includes:

  • Drop support for Java 8
  • Remove functional dependencies on HttpURLConnection
  • Remove most deprecated classes and methods
  • Remove all "bridge methods"

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 81.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 81.74%. Comparing base (9e9e775) to head (963900f).

Files with missing lines Patch % Lines
...hsuke/github/extras/HttpClientGitHubConnector.java 83.33% 4 Missing and 1 partial ⚠️
src/main/java/org/kohsuke/github/GHMyself.java 0.00% 4 Missing ⚠️
...ava/org/kohsuke/github/GitHubRateLimitHandler.java 76.47% 3 Missing and 1 partial ⚠️
...c/main/java/org/kohsuke/github/GHOrganization.java 25.00% 3 Missing ⚠️
...va/org/kohsuke/github/GitHubAbuseLimitHandler.java 90.47% 2 Missing ⚠️
src/main/java/org/kohsuke/github/GitHubClient.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1860      +/-   ##
============================================
+ Coverage     81.36%   81.74%   +0.37%     
+ Complexity     2465     2303     -162     
============================================
  Files           239      231       -8     
  Lines          7475     6967     -508     
  Branches        402      376      -26     
============================================
- Hits           6082     5695     -387     
+ Misses         1146     1038     -108     
+ Partials        247      234      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwiseman bitwiseman changed the title Move to version 2.x Version 2.0-alpha-1 Sep 14, 2024
@bitwiseman bitwiseman marked this pull request as ready for review September 14, 2024 18:52
@bitwiseman bitwiseman changed the title Version 2.0-alpha-1 Begin 2.x release train Sep 14, 2024
@bitwiseman bitwiseman closed this Sep 15, 2024
@bitwiseman bitwiseman deleted the main-2.x branch September 15, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant