-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #387: numeric value out of range of int #388
Fix for #387: numeric value out of range of int #388
Conversation
As I didn't made the tests run on my local machine please do this before merging. Feel free to contact me if there any issues regarding the upgraded dependencies. |
This is hitting us pretty badly as github just recently overflowed int on their status objects and this is causing the GitHub status post-build action to fail when deserializing responses from GitHub |
I created a ticket for this in JIRA |
@aburmeis I tried building this patch today and got build failures
|
We're also hit by the GitHub status API ID issue. Looking forward to see this patch released 👍 |
works now? how to get this version? @kohsuke |
@opethe1st: the fix is included in release 1.90 |
I've upgrade to 1.90. But i'm facing the same issue during sonar execution in my PR. |
I'm receiving the same error... I already updated to 1.9 |
Looks like Jackson is still deserializing int, not long. |
I can confirm. Still getting the error after upgrading to 1.9.
I'm using https://groups.google.com/forum/#!topic/sonarqube/2RpOwd3F7sM |
given the stack in #388 (comment) , to have Requester calling ObjectMapper.readValue at line 520, it means that you are still using an older version of github-api. it doesn't corresponds to 1.90 version see here. So it might be "just" that the sonar-github 1.4.2 needs to be deployed on the Sonar side. |
Upgrading to github-api v1.90 worked for us for the GitHub PR Builder plugin portion of our build. The response is deserialized correctly and the status is updated in the PR. However, the SonarQube scanning portion of our pipeline (preview analysis) is failing due to the SonarQube GitHub plugin v1.4.1 still using an older version of the github-api (< v1.90). Once the SonarQube GitHub plugin v1.4.2 is released I believe this will be resolved. |
Were the dependency upgrades actually needed, or just thrown in "just because"? |
@kisoku sorry for not relying, have been on vacation (no network, middle of red sea). As I wrote, I didn't manage to run the tests locally (maybe some hint in README or a CONTRIBUTION with the requirements would help). Currently a little confused about the state: last message was still not working, but is merged?!? What do do now? |
At least it works for us except Sonar for now. |
sonar-github-plugin 1.4.2 was released and published on the update center (available for on premise installation). The update on SonarCloud should be done quickly. |
http://update.sonarsource.org/update-center.properties seems updated. SonarQube update center UI is refreshed every hour. |
Seems broken, I see a version mismatch in the file.
|
Oups, problem reported. Should be fixed in a minute. Thanks for the notice. |
After upgrading to sonar-github-plugin 1.4.2 on sonarqube server, its working fine. Thanks for the fix. |
After upgrading github-api plugin to 1.90, I got this error
I've not changed anything in my Gradle build script. |
@hierony94 I would recommend asking on the Gradle mailing list, I guess people there will be more able to understand what is wrong. |
fix for #387: