Improved Pull Request review and comments support #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes parsing of response of WS call submitting a review to fail when event of new review is REQUEST_CHANGES also, specifying event when creating a pending PR review is useless and providing it when submitting the review is enough
position of pr comment is null when comment is outdated (ie. not located in diff patch anymore)
sns-seb
force-pushed
the
improved_pr_review_and_comments
branch
from
024ca30
to
e74346f
Compare
|
updated the PR to replace SonarSource license headers of new file with MIT license headers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At SonarSource, we have been using the Github API library for a while.
Unfortunately to implement new features in SonarQube, we hit some limitations.
Support for Pull Request reviews is out of date. Only support for beta has been done, and things changed a bit when the feature got public:
Pull Request comment support has some limitations and bugs:
So we added it to an internal fork and are contributing it back to the community.
Unit test coverage of the changes are far from SonarSource's standard, but we mostly failed at making existing unit tests run (mostly by a lack of the right Github credentials, it seems) so we barely added any new one.
If you have any direction to provide in order to successfully run the existing UTs, we will be happy to provide UT coverage on our new code.
In the mean time, rest assured that the new code has been field tested.
Please let us know if the contribution is acceptable in the shape below. We will be happy to drop our internal fork in favor of the original library when the changes are merged.
Cheers,