FIX #51 possibility to add checksum #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav
reviewed
Oct 21, 2016
| @@ -41,4 +41,5 @@ | |||
| $nexus_data_folder = undef | |||
| $download_folder = '/srv' | |||
| $manage_config = true | |||
| $md5sum = '' | |||
There was a problem hiding this comment.
Why does this default to empty string instead of undef?
There was a problem hiding this comment.
You're right the undef value is better. I change it!
pranav
reviewed
Oct 25, 2016
| @@ -24,6 +24,7 @@ | |||
| 'revision' => '01', | |||
| 'version' => '2.11.2', | |||
| 'download_folder' => '/srv', | |||
| 'md5sum' => '', | |||
There was a problem hiding this comment.
is this supposed to be undef now?
There was a problem hiding this comment.
You are almost right.
md5sum can not be used with undef value, that will cause during test:
ruby -c spec/classes/package_spec.rb
spec/classes/package_spec.rb:27: syntax error, unexpected keyword_undef
'md5sum' => undef,
^
spec/classes/package_spec.rb:115: syntax error, unexpected keyword_end, expecting '}'
rake aborted!
Command failed with status (1): [ruby -c spec/classes/package_spec.rb...]
caused by undef can not be used in hash
The empty value is used to be compatible with strict mode during the test
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature to set the checksum.
To use you must use the optional parameter
md5sumFor example