Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/linting #8

Closed
wants to merge 4 commits into from
Closed

Ci/linting #8

wants to merge 4 commits into from

Conversation

AlexKMarshall
Copy link
Collaborator

This sets up linting on the React side. Mainly following information from https://www.robertcooper.me/using-eslint-and-prettier-in-a-typescript-project and facebook/create-react-app#8849

Add the following to your VSCode settings.json file to automatically apply linter fixes when you save files

{
  "editor.codeActionsOnSave": {
    "source.fixAll.eslint": true
  },
}

Note that the .env file for the client side is committed to the repo as described at https://create-react-app.dev/docs/adding-custom-environment-variables/

Secret variables must not be added to this file, as they will be visible in the final build of the client.

This PR also adds a pre-commit hook to run the linter. It will fix automatically any files it can, but anything that it can't fix automatically will cause the commit to fail until you fix them manually.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2020

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #8   +/-   ##
======================================
  Coverage    2.27%   2.27%           
======================================
  Files           3       3           
  Lines          44      44           
  Branches       12      12           
======================================
  Hits            1       1           
  Misses         43      43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9833de4...41a080b. Read the comment docs.

@AlexKMarshall AlexKMarshall marked this pull request as draft August 14, 2020 15:31
@AlexKMarshall
Copy link
Collaborator Author

This is replaced by #16

@AlexKMarshall AlexKMarshall deleted the ci/linting branch August 14, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants