Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observe validator changes #266

Merged
merged 2 commits into from
Jan 19, 2017
Merged

Observe validator changes #266

merged 2 commits into from
Jan 19, 2017

Conversation

AKolodeev
Copy link
Contributor

@AKolodeev AKolodeev commented Dec 27, 2016 •
edited
Loading

I got in a situation when I needed to change validator depending on a condition. So I added validator observing.

@hueitan
Copy link
Owner

hueitan commented Dec 27, 2016

Thanks @AKolodeev Do you mind add some test cases to verify this feature?

@coveralls
Copy link

coveralls commented Dec 27, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 93.656% when pulling 1a7f8f8 on AKolodeev:validator-observing into c92d8d7 on huei90:master.

@hueitan
Copy link
Owner

hueitan commented Dec 30, 2016

@AKolodeev

@AKolodeev
Copy link
Contributor Author

@huei90, I am going to add tests next week. Thanks for reminding :)

@coveralls
Copy link

coveralls commented Jan 19, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 93.958% when pulling 21dd54a on AKolodeev:validator-observing into c92d8d7 on huei90:master.

@AKolodeev
Copy link
Contributor Author

@huei90, thanks for waiting :) I've finally done it!

@hueitan
Copy link
Owner

hueitan commented Jan 19, 2017

Thanks for this @AKolodeev !!! merge!

@hueitan hueitan merged commit aa13b20 into hueitan:master Jan 19, 2017
@AKolodeev AKolodeev deleted the validator-observing branch January 19, 2017 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AKolodeev @hueitan @coveralls