fix dropped id when restoring indexlabel #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I36a804fd2369e9d6ecc0f7317995300f6d9f4dc4 fixed: hugegraph-tools #81
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
============================================
+ Coverage 76.94% 76.95% +0.01%
Complexity 869 869
============================================
Files 143 143
Lines 3808 3810 +2
Branches 225 225
============================================
+ Hits 2930 2932 +2
Misses 712 712
Partials 166 166
Continue to review full report at Codecov.
|
javeme
approved these changes
Mar 22, 2021
houzhizhen
approved these changes
Mar 22, 2021
javeme
reviewed
Mar 23, 2021
| @@ -273,6 +273,7 @@ public IndexLabelV56(IndexLabel indexLabel) { | |||
| super(indexLabel.name); | |||
| E.checkArgument(indexLabel.rebuild, | |||
| "The rebuild of indexlabel must be true"); | |||
| this.id = indexLabel.id(); | |||
There was a problem hiding this comment.
no need right now. This bug only affects the situation that using hugegraph-tools 1.5 migrate/restore indexlabels to HugeGraphServer 0.10.
Linary
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: hugegraph-tools #81
Change-Id: I36a804fd2369e9d6ecc0f7317995300f6d9f4dc4