Let vertex and edge adapt simple json properties #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linary
force-pushed
the
adapt-simple-json-props
branch
from
5cff071 to
2e8c2e8
Compare
Linary
force-pushed
the
adapt-simple-json-props
branch
2 times, most recently
from
bc69094 to
6412011
Compare
javeme
requested changes
Mar 5, 2019
| @@ -96,7 +96,7 @@ private void initManagers(RestClient client, String graph) { | |||
| private void checkServerApiVersion() { | |||
| VersionUtil.Version apiVersion = VersionUtil.Version.of( | |||
| this.version.getApiVersion()); | |||
| VersionUtil.check(apiVersion, "0.32", "0.33", | |||
| VersionUtil.check(apiVersion, "0.34", "0.35", | |||
There was a problem hiding this comment.
0.33 is customized path api
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| private final ObjectMapper mapper; | |||
|
|
|||
| public VertexDeserializer() { | |||
| private VertexDeserializer() { | |||
Linary
force-pushed
the
adapt-simple-json-props
branch
3 times, most recently
from
c032c0f to
363df59
Compare
Implement #36 Change-Id: I500976931c50fbab384dbd71dbd839aa69dc42d3
Linary
force-pushed
the
adapt-simple-json-props
branch
from
363df59 to
b652ff5
Compare
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=========================================
Coverage ? 72.47%
Complexity ? 459
=========================================
Files ? 90
Lines ? 2016
Branches ? 115
=========================================
Hits ? 1461
Misses ? 469
Partials ? 86
Continue to review full report at Codecov.
|
zhoney
previously approved these changes
Mar 13, 2019
javeme
requested changes
Mar 13, 2019
| + "\"city\": \"Shanghai\"," | ||
| + "\"name\": \"peter\"," | ||
| + "\"age\": 29" | ||
| + "}" |
There was a problem hiding this comment.
add test for list/set property
There was a problem hiding this comment.
now list/set property will be parsed into a list
Linary
force-pushed
the
adapt-simple-json-props
branch
from
a6c7284 to
dfed778
Compare
Change-Id: I3decf4857478a9a6e5d3e0a87a931a8136ca8469
Linary
force-pushed
the
adapt-simple-json-props
branch
from
dfed778 to
362609e
Compare
javeme
approved these changes
Mar 13, 2019
zhoney
approved these changes
Mar 13, 2019
zhoney
pushed a commit
to zhoney/hugegraph-client
that referenced
this pull request
Sep 19, 2019
Let vertex and edge adapt simple json properties Implement hugegraph#36 Change-Id: I500976931c50fbab384dbd71dbd839aa69dc42d3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #36
Change-Id: I500976931c50fbab384dbd71dbd839aa69dc42d3