Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to schedule async task in cluster #89

Merged
merged 3 commits into from
Jul 3, 2020
Merged

Conversation

zhoney
Copy link
Contributor

@zhoney zhoney commented Jul 3, 2020

Change-Id: I5b056c102ce07d4b30c7c3455c51285712a17131

zhoney added 2 commits July 3, 2020 19:40
Change-Id: I5b056c102ce07d4b30c7c3455c51285712a17131
Change-Id: I81f61adfaec763fd622dd834ccd4c9da37420dd5
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #89 into master will increase coverage by 0.48%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
+ Coverage     77.00%   77.48%   +0.48%     
- Complexity      783      784       +1     
============================================
  Files           127      127              
  Lines          3244     3225      -19     
  Branches        192      187       -5     
============================================
+ Hits           2498     2499       +1     
+ Misses          607      587      -20     
  Partials        139      139              
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/baidu/hugegraph/structure/Task.java 31.81% <66.66%> (+17.18%) 6.00 <2.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695fa56...815534b. Read the comment docs.

Linary
Linary previously approved these changes Jul 3, 2020
Assert.assertEquals("Can't query by paging and filtering",
e.getMessage());
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete empty line

@@ -161,6 +172,9 @@ public boolean success() {
if (this.dependencies != null) {
map.put(P.DEPENDENCIES, this.dependencies);
}
if (this.server != null) {
map.put(P.SERVER, this.server);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must set?

Change-Id: I0f0d35c78d283034dc1e2a76f795bebf01db4807
@javeme javeme merged commit 88f9545 into master Jul 3, 2020
@javeme javeme deleted the adapt-schedule-async-task branch July 3, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants