Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing parentheses when calling is_xpu_avaliable #2637

Closed
ArthurinRUC opened this issue Apr 9, 2024 · 2 comments · Fixed by #2639
Closed

missing parentheses when calling is_xpu_avaliable #2637

ArthurinRUC opened this issue Apr 9, 2024 · 2 comments · Fixed by #2639

Comments

@ArthurinRUC
Copy link
Contributor

Hi, I wonder if the code is missing a pair of parentheses when calling is_xpu_avaliable, should it be is_xpu_avaliable() instead?

if is_xpu_available and is_ccl_available():
os.environ["CCL_PROCESS_LAUNCHER"] = "none"
os.environ["CCL_LOCAL_SIZE"] = os.environ.get("LOCAL_WORLD_SIZE", "1")
os.environ["CCL_LOCAL_RANK"] = os.environ.get("LOCAL_RANK", "0")

@muellerzr
Copy link
Collaborator

Yes indeed! Would you like to make a PR? :)

@ArthurinRUC
Copy link
Contributor Author

Thanks a lot :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants