Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parenthesis on xpu_available #2639

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Parenthesis on xpu_available #2639

merged 1 commit into from
Apr 9, 2024

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

This existed before the refactor, but we are missing parenthesis around one of the calls to is_xpu_available

Fixes #2637

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@BenjaminBossan

@muellerzr muellerzr requested a review from BenjaminBossan April 9, 2024 10:10
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Would be nice if the linter could catch this, checking bool on a function is probably unintended 99.99% of the time.

@muellerzr muellerzr merged commit df485ae into main Apr 9, 2024
25 checks passed
@muellerzr muellerzr deleted the is_xpu branch April 9, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing parentheses when calling is_xpu_avaliable
3 participants