Handle UserDict in all utils #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgugger @LysandreJik Instead of adding |
|
Oh thanks for the tip! I will clean the code to use that when I have a bit of time (unless you want to suggest a PR!) |
|
I'm busy currently, so probably won't find time to fix this myself. |
|
I did find time to fix this, so I've opened a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all the reclusive utility functions defined in the
utilsmodule handle nested lists and dictionaries of a base type (usually tensors) but notUserDict, which is not considered an instance ofdict.This cause problems with the
BatchEncodingtype in Transformers (which is aUserDictso is not considered a subclass ofdict) as pointed out by #178. This PR addresses that issue.Fixes #178