-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] enable XPU backend for test_zero3_integration
#2864
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, overall this looks okay to me with this. We can try the other devices as long as you can test them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM !
@SunMarc can we proceed with merging? Thanks so much! |
…er` within the `Accelerator` (#2895) * temporary commit * checkout? * dataloader wrapper * tmp * weird failing test * trying multiple inheritance * DataLoaderAdapter * make style * Some dark magic dynamic reflection (for backwards compat) * typo * some tests * more mixin stuff * maybe found broken test? * this is a very invasive feature * i think the feature is done? * add xpu support (#2864) * better tests * discovered a bug * maybe fixed bug? * make style * hopefully this is PR ready * properly skip tests * parameterize * temporary commit * checkout? * dataloader wrapper * tmp * weird failing test * trying multiple inheritance * DataLoaderAdapter * make style * Some dark magic dynamic reflection (for backwards compat) * typo * some tests * more mixin stuff * maybe found broken test? * this is a very invasive feature * i think the feature is done? * better tests * discovered a bug * maybe fixed bug? * make style * hopefully this is PR ready * properly skip tests * parameterize * Update src/accelerate/utils/dataclasses.py Co-authored-by: Zach Mueller <muellerzr@gmail.com> * Update src/accelerate/data_loader.py Co-authored-by: Zach Mueller <muellerzr@gmail.com> * merge conflicts * move imports * make style * merges are breaking tests * fix test name * Require safetensors>=0.4.3 * undo last commit * minor style * address pr comments * Torchdata version 0.8.0 is stable now * added docs and require torchdata>=0.8.0 for testing * test base_dataloader attr doesn't cause infinite recursion * address pr * replace super().__iter__ with self.base_dataloader.__iter__ --------- Co-authored-by: Fanli Lin <fanli.lin@intel.com> Co-authored-by: Zach Mueller <muellerzr@gmail.com>
What does this PR do?
python -m pytest -rA -k "test_zero3_integration" tests/deepspeed
The command above gives the following error:
Pls let me know if I need to add support for other devices as well. @muellerzr @SunMarc