Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle negative values for dim input in pad_across_processes #3114

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

mariusarvinte
Copy link
Contributor

@mariusarvinte mariusarvinte commented Sep 14, 2024

What does this PR do?

Fixes #3113 by explicitly checking and handling padding on negative dimensions for accelerate.utils.pad_across_processes.

Adds tests for handling valid and out-of-bounds negative dimensions.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@muellerzr @BenjaminBossan @SunMarc

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this functionality and a test! :)

@muellerzr muellerzr requested a review from SunMarc October 8, 2024 12:23
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice way to handle this! LGTM!

@SunMarc SunMarc merged commit ae9cb6e into huggingface:main Oct 8, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accelerate.utils.pad_across_processes does not support negative dim argument
3 participants