Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Megatron-LM plugin code to version 0.8.0 or higher. #3174

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

eljandoubi
Copy link
Contributor

What does this PR do?

I have adapted the Megatron-LM plugin code to version 0.8.0 or higher.
Same setup as before, but now Megatron-LM is using core_r0.8.0.

Who can review?

@eljandoubi eljandoubi changed the title I have adapted the Megatron-LM plugin code to version 0.8.0 or higher. update Megatron-LM plugin code to version 0.8.0 or higher. Oct 22, 2024
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the old code work from 0.5 -> 0.7.0? I'd rather see if/else checks rather than fully always bump the user up to the latest.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@eljandoubi
Copy link
Contributor Author

eljandoubi commented Oct 24, 2024

No! In fact, functions and classes of Megatron-LM change their location from version to another.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine I suppose then. Thanks :)

@muellerzr
Copy link
Collaborator

(Failing tests are unrelated, python update)

@muellerzr muellerzr merged commit 2f39575 into huggingface:main Oct 24, 2024
16 of 25 checks passed
@eljandoubi
Copy link
Contributor Author

Megatron-LM 0.9.0 is out. I believe the plugin is still functional. Can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants