Fix align_module_device
, ensure only cpu tensors for get_state_dict_offloaded_model
#3217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
align_module_device
#3204 introduce an unintended behavior change where a module being aligned would also attempt to align parameters belonging to its submodules. This is a problem for functions likeget_state_dict_offloaded_model
which callsalign_module_device
on non-leaf modules.Purpose
align_module_device
bug where the function attempts to align meta tensors belonging to submodule parametersget_state_dict_offloaded_model(model)
behavior to matchmodel.state_dict()
get_state_dict_offloaded_model
Changes
align_module_device
now only aligns parameters directly attached to the parentget_state_dict_offloaded_model
Testing
test_e2e.py