Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle deprication errors in launch #360

Merged
merged 7 commits into from
May 12, 2022
Merged

Handle deprication errors in launch #360

merged 7 commits into from
May 12, 2022

Conversation

muellerzr
Copy link
Collaborator

  • Checks for the right launcher based on the torch version
  • Adds num_cpu_threads_per_process and sets it to env to get rid of torchrun warning. Default is torchrun default

@muellerzr muellerzr requested a review from sgugger May 12, 2022 14:03
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 12, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@muellerzr muellerzr marked this pull request as draft May 12, 2022 14:14
@muellerzr muellerzr marked this pull request as ready for review May 12, 2022 14:41
sgugger
sgugger approved these changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dealing with this!

src/accelerate/utils/versions.py Outdated Show resolved Hide resolved
@muellerzr muellerzr merged commit 1700716 into main May 12, 2022
@muellerzr muellerzr deleted the launch branch May 12, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger