-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce no_sync
context wrapper + clean up some more warnings for DDP
#428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sgugger good for a rereview, slow test logs can be seen here passing: https://github.com/huggingface/accelerate/runs/6794400970?check_suite_focus=true |
sgugger
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on this!
Just missing a by-feature example of use :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
no_sync
context wrapperWhat does this add?
no_sync
wrapper that shadowstorch.nn.parallel.DistributedDataParallel.no_sync
but will do nothing if we're not in a DDP processtorchrun
into a separate util to make reusing it in tests + launch easierWhy is it needed?
This lets us use Accelerator eventually for gradient accumulation
What parts of the API does this impact?
User-facing:
Accelerator.no_sync(model)
to perform the equivalent ofmodel.no_sync()
(if in ddp, if not it does nothing)Non-user facing:
no_sync
in PyTorch to ensure those work, and CPU tests to make sure that when not in DDP it's anoop
context manager