Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm gradient accumulation on TPU #479

Merged
merged 4 commits into from
Jun 28, 2022
Merged

Rm gradient accumulation on TPU #479

merged 4 commits into from
Jun 28, 2022

Conversation

muellerzr
Copy link
Collaborator

@muellerzr muellerzr commented Jun 28, 2022

Removes gradient accumulation from all examples if on a TPU as there's a major bug within it apparently on the xla side. Will investigate further eventually.

Closes #452
Closes #450

@muellerzr muellerzr added bug Something isn't working TPU Bug or feature on TPU platforms labels Jun 28, 2022
@muellerzr muellerzr requested a review from sgugger June 28, 2022 15:28
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 28, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this!

examples/by_feature/gradient_accumulation.py Outdated Show resolved Hide resolved
examples/complete_nlp_example.py Outdated Show resolved Hide resolved
examples/nlp_example.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working TPU Bug or feature on TPU platforms
Projects
None yet
3 participants