Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable Gather for Metrics #590

Merged
merged 13 commits into from
Aug 2, 2022
Merged

Reenable Gather for Metrics #590

merged 13 commits into from
Aug 2, 2022

Conversation

muellerzr
Copy link
Collaborator

Enables gather for metrics again as the tests now pass due to fixes in #588

@muellerzr muellerzr added bug Something isn't working enhancement New feature or request labels Aug 1, 2022
@muellerzr muellerzr requested review from pacman100 and sgugger August 1, 2022 20:28
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 1, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-enabling this feature!

pacman100
pacman100 reviewed Aug 2, 2022
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🤗! As seen last time, test_metrics.py fails for DataLoaderDispatcher num_samples=97 or num_samples=99, i.e., whenever observed_batch_size % self.state.num_processes !=0
Screenshot 2022-08-02 at 6 55 28 PM
Screenshot 2022-08-02 at 6 56 18 PM

@muellerzr muellerzr force-pushed the gather_for_metrics branch 2 times, most recently from f216820 to eca63b2 Compare August 2, 2022 13:54
@muellerzr muellerzr force-pushed the gather_for_metrics branch from eca63b2 to ca65276 Compare August 2, 2022 13:54
@muellerzr muellerzr force-pushed the gather_for_metrics branch from cee639e to 7f6a06e Compare August 2, 2022 14:51
@muellerzr muellerzr requested a review from sgugger August 2, 2022 16:48
@muellerzr muellerzr merged commit 8944975 into main Aug 2, 2022
@muellerzr muellerzr deleted the gather_for_metrics branch August 2, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 left review comments

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muellerzr @HuggingFaceDocBuilderDev @pacman100 @sgugger