-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving hyperparams in yaml file for Tensorboard for #521 #657
Saving hyperparams in yaml file for Tensorboard for #521 #657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! I left one comment just to make sure if we want to store it to the current dir or the already existing logging_dir
The documentation is not available anymore as the PR was closed or merged. |
cc @nateraw if you have any comments 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments here - will try to give it a try in an hour to give more detailed feedback if I have any.
@Shreyz-max cast Great work on this, were almost there! |
Yeah, sorry about the mistake. I did not notice this at all. |
I suppose I need to create the folder. |
Great job! CC @nateraw for one last look, but lg2m! |
This PR saves the hyperparameters in a YAML file for Tensorboard tracker. By default, the HParams dashboard currently requires at least one hparam and at least one metric defined in the hparams configuration but since we have no metric, the hyperparameters will be stored in a YAML file . The changes have been implemented in
tracking.py
.