Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving hyperparams in yaml file for Tensorboard for #521 #657

Merged
merged 7 commits into from
Aug 29, 2022

Conversation

Shreyz-max
Copy link
Contributor

This PR saves the hyperparameters in a YAML file for Tensorboard tracker. By default, the HParams dashboard currently requires at least one hparam and at least one metric defined in the hparams configuration but since we have no metric, the hyperparameters will be stored in a YAML file . The changes have been implemented in tracking.py.

@muellerzr muellerzr self-requested a review August 24, 2022 19:47
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I left one comment just to make sure if we want to store it to the current dir or the already existing logging_dir

src/accelerate/tracking.py Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 24, 2022

The documentation is not available anymore as the PR was closed or merged.

@muellerzr
Copy link
Collaborator

cc @nateraw if you have any comments 🤗

Copy link
Contributor

@nateraw nateraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments here - will try to give it a try in an hour to give more detailed feedback if I have any.

src/accelerate/tracking.py Outdated Show resolved Hide resolved
src/accelerate/tracking.py Outdated Show resolved Hide resolved
src/accelerate/tracking.py Outdated Show resolved Hide resolved
@muellerzr
Copy link
Collaborator

@Shreyz-max cast run_name to a string on the yaml part and it should solve the error. E.g. str(run_name)

Great work on this, were almost there!

@Shreyz-max
Copy link
Contributor Author

Yeah, sorry about the mistake. I did not notice this at all.

@Shreyz-max
Copy link
Contributor Author

I suppose I need to create the folder.

@muellerzr
Copy link
Collaborator

Great job! CC @nateraw for one last look, but lg2m!

@muellerzr muellerzr merged commit cb54e10 into huggingface:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants