Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sagemaker fixes and improvements #708

Merged
merged 2 commits into from
Sep 22, 2022
Merged

sagemaker fixes and improvements #708

merged 2 commits into from
Sep 22, 2022

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Adding AWS Sagemaker examples to accelerate/examples README.md file.
  2. Help users correctly leverage it going forward as it is at times not clear. (issue Have accelerate for Distributed Training: Data Parallelism feature working on AWS Sagemaker yet? #706 ).

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 21, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@pacman100 pacman100 merged commit 6a39d01 into huggingface:main Sep 22, 2022
@pacman100 pacman100 deleted the smangrul/improve-example-readme branch September 22, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@philschmid philschmid Awaiting requested review from philschmid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacman100 @HuggingFaceDocBuilderDev @sgugger