Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how-to-train.md #2

Merged
merged 1 commit into from
Feb 15, 2020
Merged

Update how-to-train.md #2

merged 1 commit into from
Feb 15, 2020

Conversation

BramVanroy
Copy link
Contributor

.open() files should be closed. As currently written, the opened file handles were never closed - which might cause issues when the same file is used around different processes at the same time. This proposed change uses pathlib's built-in read_text which opens the file, reads contents, and closes it immediately in one go.

`.open()` files should be closed. As currently written, the opened file handles were never closed - which might cause issues when the same file is used around different processes at the same time. This proposed change uses pathlib's built-in `read_text` which opens the file, reads contents, and closes it immediately in one go.
@julien-c julien-c merged commit e3033ed into huggingface:master Feb 15, 2020
@julien-c
Copy link
Member

Good catch, thanks! will fix the whitespace in next commit

@BramVanroy BramVanroy deleted the patch-1 branch February 15, 2020 18:11
dylanebert added a commit that referenced this pull request Feb 7, 2023
dylanebert added a commit that referenced this pull request Feb 7, 2023
dylanebert added a commit that referenced this pull request Feb 7, 2023
* starting part 5 post

* tweaked thumbnail

* tweaked thumbnail #2

* first pass

* small tweaks

* Update ml-for-games-5.md

Co-authored-by: Julien Chaumond <julien@huggingface.co>

* Update ml-for-games-5.md

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* Update ml-for-games-5.md

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* discord link update

* more visible open source agents early on, segue into where we're headed, added bard

* added mention of watermarking

* Update ml-for-games-5.md

Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>

* Update ml-for-games-5.md

Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>

* Update ml-for-games-5.md

Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>

* Update ml-for-games-5.md

Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>

* Update ml-for-games-5.md

Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>

* convert papers to list

* updated date, added game link

* updated link to tiktok

---------

Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>
Wauplin pushed a commit that referenced this pull request Oct 21, 2024
* blog post explaining how to load Llama 3.2 in Keras

* added table of contents entry

* merged tebale of contents

* additional visual assets

* renaming files to conform to standard

* finalized keras blog post + assets

* typo fixes

* a couple of edits to the blog post

* removed unused file

* fixed thumbnail

* fix #2 for keras post thumbnail
ariG23498 pushed a commit to ariG23498/blog that referenced this pull request Dec 18, 2024
Update bamba.md - Safety results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants