-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add] Logits Processor Zoo with HF Transformers #2524
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on putting this together, it already reads well. I added some suggestion/ nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for incorporating the suggestions:
Two final suggestions:
- Put a more generic title - if possible.
- After each generation, add a line that tells people what to look for specifically in that generation and how it relates to the LogitProcessor.
@Vaibhavs10 thank you for the review! I have updated the blog according to your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! <3
Waiting for the NVIDIA team to review. After that is done we can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some additional contextualization could be helpful, as expressed in a comment.
_blog.yml
Outdated
title: "Controlling Language Model Generation with NVIDIA's LogitsProcessorZoo" | ||
author: ariG23498 | ||
thumbnail: /blog/assets/logits-processor-zoo/thumbnail.png | ||
date: December 11, 2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to update
logits-processor-zoo.md
Outdated
- user: aerdem | ||
guest: true | ||
org: nvidia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This author profile does not seem to belong to the nvidia org.
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to Pedro's contextualization comment
If a reader skims the top, it gives the impression that transformers
doesn't include advanced logits processors (which is obviously not true 😛 ). Instead, I would try to frame Nvidia's library as an expansion to the existing processors, and would also highlight that generate
is compatible with custom logits processors like Nvidia's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the intro and skimmed through the rest, given that several of us had already reviewed. The context and framing look great to me now!
org: nvidia | ||
--- | ||
|
||
# Controlling Language Model Generation with NVIDIA's LogitsProcessorZoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love how the intro provides great context now, thank you! 🙌
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Adding a blog post on logits processor zoo from NVIDIA and its usage with Hugging Face transformers.