Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #2547

Closed
wants to merge 35 commits into from
Closed

Conversation

raghukiran1224
Copy link
Contributor

@raghukiran1224 raghukiran1224 commented Dec 17, 2024

Congratulations! You've made it this far! Once merged, the article will appear at https://huggingface.co/blog. Official articles
require additional reviews. Alternatively, you can write a community article following the process here.

Preparing the Article

You're not quite done yet, though. Please make sure to follow this process (as documented here):

  • Add an entry to _blog.yml.
  • Add a thumbnail. There are no requirements here, but there is a template if it's helpful.
  • Check you use a short title and blog path.
  • Upload any additional assets (such as images) to the Documentation Images repo. This is to reduce bloat in the GitHub base repo when cloning and pulling. Try to have small images to avoid a slow or expensive user experience.
  • Add metadata (such as authors) to your md file. You can also specify guest or org for the authors.
  • Ensure the publication date is correct.
  • Preview the content. A quick way is to paste the markdown content in https://huggingface.co/new-blog. Do not click publish, this is just a way to do an early check.

Here is an example of a complete PR: #2382

Getting a Review

Please make sure to get a review from someone on your team or a co-author.
Once this is done and once all the steps above are completed, you should be able to merge.
There is no need for additional reviews if you and your co-authors are happy and meet all of the above.

Feel free to add @pcuenca as a reviewer if you want a final check. Keep in mind he'll be biased toward light reviews
(e.g., check for proper metadata) rather than content reviews unless explicitly asked.

@raghukiran1224 raghukiran1224 marked this pull request as draft December 17, 2024 16:25
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Made a few suggestions that you can safely ignore, of course. We can help move the images to the external dataset in a few hours.

_blog.yml Outdated Show resolved Hide resolved
_blog.yml Outdated Show resolved Hide resolved
_blog.yml Outdated Show resolved Hide resolved
assets/bamba/ArithmeticIntensity.png Outdated Show resolved Hide resolved
assets/bamba/bamba_llama_latencies_ratios.png Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
raghukiran1224 and others added 16 commits December 17, 2024 21:22
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
bamba.md Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
bamba.md Outdated Show resolved Hide resolved
_blog.yml Show resolved Hide resolved
raghukiran1224 and others added 6 commits December 18, 2024 08:43
Co-authored-by: Aritra Roy Gosthipaty <aritra.born2fly@gmail.com>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
bamba.md Outdated Show resolved Hide resolved
@raghukiran1224 raghukiran1224 marked this pull request as ready for review December 18, 2024 16:14
_blog.yml Outdated Show resolved Hide resolved
raghukiran1224 and others added 2 commits December 18, 2024 11:25
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
@pcuenca pcuenca mentioned this pull request Dec 18, 2024
@pcuenca pcuenca closed this Dec 18, 2024
pcuenca added a commit that referenced this pull request Dec 18, 2024
* bamba

* updating blog yml

* updating prompt

* updating with minor fixes

* Update bamba.md - Safety results

* adding first rev of authors, more to come

* updating with comments from Tri, Stas, Albert

* updating another round of comments

* Update _blog.yml

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* fixed _blog.yml, changed the thumbnail aspect ratio and extension

* Update bamba.md

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* adding org info

* Update bamba.md

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* Update bamba.md

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* Update bamba.md

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* Update bamba.md

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* Update bamba.md

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* Update bamba.md

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* Update bamba.md

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* Update bamba.md

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* Update bamba.md

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* Apply suggestions from code review

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* updating the authors

* resolving more things

* Update bamba.md

Co-authored-by: Aritra Roy Gosthipaty <aritra.born2fly@gmail.com>

* Apply suggestions from code review

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* Apply suggestions from code review

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* updating with comments from review

* updating with links and some changes in intro to ack Falcon3

* Update _blog.yml

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* updating across the board

* Update _blog.yml

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* removing images

* title in yaml

---------

Co-authored-by: RAGHU KIRAN GANTI <rganti@us.ibm.com>
Co-authored-by: OfirArviv <ofirarviv@gmail.com>
Co-authored-by: Raghu Ganti <raghukiran@gmail.com>
Co-authored-by: Aritra Roy Gosthipaty <aritra.born2fly@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants