-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo #2547
Closed
Closed
fix typo #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update bamba.md - Safety results
pcuenca
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Made a few suggestions that you can safely ignore, of course. We can help move the images to the external dataset in a few hours.
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
ariG23498
reviewed
Dec 18, 2024
pcuenca
reviewed
Dec 18, 2024
pcuenca
reviewed
Dec 18, 2024
pcuenca
reviewed
Dec 18, 2024
Co-authored-by: Aritra Roy Gosthipaty <aritra.born2fly@gmail.com>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
pcuenca
reviewed
Dec 18, 2024
pcuenca
reviewed
Dec 18, 2024
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Merged
pcuenca
added a commit
that referenced
this pull request
Dec 18, 2024
* bamba * updating blog yml * updating prompt * updating with minor fixes * Update bamba.md - Safety results * adding first rev of authors, more to come * updating with comments from Tri, Stas, Albert * updating another round of comments * Update _blog.yml Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * fixed _blog.yml, changed the thumbnail aspect ratio and extension * Update bamba.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * adding org info * Update bamba.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Update bamba.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Update bamba.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Update bamba.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Update bamba.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Update bamba.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Update bamba.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Update bamba.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Update bamba.md Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Apply suggestions from code review Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * updating the authors * resolving more things * Update bamba.md Co-authored-by: Aritra Roy Gosthipaty <aritra.born2fly@gmail.com> * Apply suggestions from code review Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * Apply suggestions from code review Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * updating with comments from review * updating with links and some changes in intro to ack Falcon3 * Update _blog.yml Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * updating across the board * Update _blog.yml Co-authored-by: Pedro Cuenca <pedro@huggingface.co> * removing images * title in yaml --------- Co-authored-by: RAGHU KIRAN GANTI <rganti@us.ibm.com> Co-authored-by: OfirArviv <ofirarviv@gmail.com> Co-authored-by: Raghu Ganti <raghukiran@gmail.com> Co-authored-by: Aritra Roy Gosthipaty <aritra.born2fly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Congratulations! You've made it this far! Once merged, the article will appear at https://huggingface.co/blog. Official articles
require additional reviews. Alternatively, you can write a community article following the process here.
Preparing the Article
You're not quite done yet, though. Please make sure to follow this process (as documented here):
md
file. You can also specifyguest
ororg
for the authors.Here is an example of a complete PR: #2382
Getting a Review
Please make sure to get a review from someone on your team or a co-author.
Once this is done and once all the steps above are completed, you should be able to merge.
There is no need for additional reviews if you and your co-authors are happy and meet all of the above.
Feel free to add @pcuenca as a reviewer if you want a final check. Keep in mind he'll be biased toward light reviews
(e.g., check for proper metadata) rather than content reviews unless explicitly asked.