Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up a couple rough edges of the
VarBuilder
, it tries to preserve the user-facing API so as not to be too much of an intrusive change.Backend
trait. All the current implementations are invar_builder.rs
but it's easy to move them/add new ones etc.get_or_init
is renamed toget_with_hints
so as not to be misleading on potential initialization (this decision is deferred to the backend).Pending/drawbacks:
Testing: