[fix] Assistant websearch text/markdown source #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishig25
force-pushed
the
fix_parse_web_plain
branch
from
8bedc94 to
b2bee62
Compare
coyotte508
reviewed
May 10, 2024
| @@ -32,7 +32,9 @@ export async function parseWeb(url: string) { | |||
| r.headers.get("content-type")?.includes("text/plain") || | |||
| r.headers.get("content-type")?.includes("text/markdown") | |||
| ) { | |||
| return r.text(); | |||
| const text = await r.text(); | |||
| // JSON.stringify is needed to turn string concatenation into a single string (ex: "Hello, " + "world!" -> "Hello, world!") | |||
There was a problem hiding this comment.
> JSON.stringify('"Hello, " + "world!"')
'"\\"Hello, \\" + \\"world!\\""'It doesn't give "Hello, world!"
Not sure I understand where the concat happens
There was a problem hiding this comment.
example:
const text = await r.text();
console.log({text})
// {text: "Hello " + "world"}and TEI endpoint was failing with Invalid json
let text = r.text();
text = JSON.stringify(text)
console.log({text})
// {text: "Hello world"}TEI endpoint works fine
There was a problem hiding this comment.
will let @nsarrazin review I don't understand it
nsarrazin
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you combine assistant websearch with TEI, there was an error. (However, it was/is working fine with local models through transformers.js).
Although we have
chat-ui/src/lib/server/embeddingEndpoints/tei/embeddingEndpoints.ts
Line 63 in b2bee62
invalid json) when a text value was a text concat value (i.e. rather than"Hello World", the actual value was"Hello " + "World"). Therefore, we needed to addchat-ui/src/lib/server/websearch/parseWeb.ts
Lines 35 to 37 in b2bee62
on main
this PR