Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(screen-reader): disable FileDropZone area-label for models without file upload #1295

Merged

Conversation

neven4
Copy link
Contributor

@neven4 neven4 commented Jun 19, 2024

Closes: #1113

Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great, thanks for the fix! 🔥

@nsarrazin nsarrazin merged commit d3298e8 into huggingface:main Jun 20, 2024
3 checks passed
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
…t file upload (huggingface#1295)

Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileDropZone visible to screen reader, even for non-multimodal models
2 participants