New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain Conversation Tree State on Refresh or Share #1397

Merged

nsarrazin merged 37 commits into huggingface:main from kramosss:persistCurrentTree

Aug 25, 2024

Contributor

kramosss commented Aug 7, 2024

Added code that maintains the current conversation tree state when refreshing the page or sharing the conversation.

Addresses issue #878

Not sure if this is the most efficient solution but will edit based on feedback.

Co-authored-by: Long Dao [hailongdao1017@gmail.com]
Co-authored-by: Eduardo Rocha [rocha092@csusm.edu]

gloodan17 and others added 28 commits

July 22, 2024 14:04


          Saving and reloading the current tree on page refresh

7da37fa


          Merge branch 'main' of https://github.com/kramosss/chat-ui

f9e8af6


          Merge branch 'huggingface:main' into main

277ff7e


          Saving and reloading the current tree on page refresh / Moving to the…

cea9887

… last branch when editing a user message or retrying an assistant message.


          Merge branch 'huggingface:main' into main

b26142a


          Update Reload the current tree state on page refresh

66175e8


          Merge branch 'huggingface:main' into main

d02bd50


          updated updateCurrentIndex function

a87ed5c


          Update Reload the current tree state on page refresh


          Merge branch 'huggingface:main' into main

0da35dc


          Merge branch 'huggingface:main' into persistCurrentTree

32d641b


          Merge branch 'huggingface:main' into main

544cf18


          Updated updateCurrentIndex Function

a0854fc


          Update updateCurrentIndex Function

6cde4b2


          Updated updateCurrentIndex function

7d9a2d5

Co-authored-by: Long Dao <hailongdao1017@gmail.com>

Co-authored-by: Eduardo Rocha <rocha092@csusm.edu>


          Update Reload the current tree state on page refresh

>
>
Co-authored-by: KENNETH <KENNETH.RAMOS95@GMAIL.COM>
Co-authored-by: EDUARDO <EDUARDOROCHAPERSONAL2@GMAIL.COM


          Merge branch 'persistCurrentTree' of https://github.com/kramosss/chat-ui

5c04ad7

 into persistCurrentTree


          Persist current tree in navigation/shared conversations v1

7b38d17

Co-authored-by: Kenneth Ramos <kenneth.ramos95@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csusm.edu>


          Merge branch 'huggingface:main' into main

23ec5c0


          Removed uncessary comment.

a524758

Co-authored-by: Long Dao <hailongdao1017@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csusm.edu>


          Merge branch 'main' of https://github.com/huggingface/chat-ui

ff86c0c

Getting the latest changes from the parent repository


          Merge branch 'main' of https://github.com/kramosss/chat-ui

5e9f2bb

Getting latest changes from remote


          Merge branch 'huggingface:main' into main

e84fe3e


          Merge branch 'main' into persistCurrentTree

a8f18f5

Co-authored-by: Long Dao <hailongdao1017@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csusm.edu>


          Added enhance import and document focus fix.

6742d8f

Co-authored-by: Long Dao <hailongdao1017@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csum.edu>


          Merge branch 'huggingface:main' into main

abde048


          Merge branch 'main' of https://github.com/kramosss/chat-ui

0142cee

Updated with parent repository


          Merge branch 'main' into persistCurrentTree

17531ed

Co-authored-by: Long Dao <hailongdao1017@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csusm.edu>

Collaborator

nsarrazin commented Aug 7, 2024

Wow really appreciate this! Will take a deep look into this 🔥

nsarrazin self-requested a review

August 7, 2024 18:58

nsarrazin self-assigned this

kramosss and others added 4 commits

August 8, 2024 10:12


          Merge branch 'huggingface:main' into main

199191d


          Merge branch 'main' of https://github.com/kramosss/chat-ui

a792e58

Co-authored-by: Long Dao <hailongdao1017@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csusm.edu>


          Merge branch 'main' into persistCurrentTree

3ad3539

Co-authored-by: Long Dao <hailongdao1017@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csusm.edu>


          Fixed code to have updated formatting and LoadEvent type in page.ts

1eaf389

Co-authored-by: Long Dao <hailongdao1017@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csusm.edu>

Contributor Author

kramosss commented Aug 8, 2024

Hi, I believe we fixed the lint issues. Could the tests be ran again to make sure everything is working?

Contributor Author

kramosss commented Aug 8, 2024

Hi, I'm a little confused as to why we're getting those errors as we didn't edit those files and when I run npm run lint in my vs code I'm not getting errors. I pretty much just ran npm run format and npm run lint then fixed the few errors that appeared. Should running npx prettier --plugin-search-dir . --write . and npx eslint . --fix be the solution to fixing the warnings?

Collaborator

nsarrazin commented Aug 8, 2024

Did you merge latest main? We updated quite some deps so it's possible the linting got changed, I can run it for you no worries


          run formatting

6687fd9

Contributor Author

kramosss commented Aug 8, 2024

Oh, thank you!

SvCy commented Aug 12, 2024

Great work!
This can help retain the tree state in the chat too, I think? working as tree memory? as refresh resets the tree to branch 1/incorrectly.

kramosss and others added 4 commits

August 12, 2024 09:57


          Merge branch 'main' into persistCurrentTree

070e759


          Merge branch 'main' into pr/kramosss/1397

e26fe33


          Merge branch 'main' into persistCurrentTree

72b6d95


          simplify pr

5c36600

nsarrazin approved these changes

View reviewed changes

Collaborator

nsarrazin left a comment

Looking good! I think in local storage we should keep a record of the shape {[convId]: leafId} so we can keep track of all conversations in memory. can be a second PR though so will merge this one in the meanwhile!

nsarrazin merged commit 9bfa251 into huggingface:main

3 checks passed

ice91 pushed a commit to ice91/chat-ui that referenced this pull request


          Maintain Conversation Tree State on Refresh or Share (huggingface#1397)

5dc99a6

* Saving and reloading the current tree on page refresh

* Saving and reloading the current tree on page refresh / Moving to the last branch when editing a user message or retrying an assistant message.

* Update Reload the current tree state on page refresh

* updated updateCurrentIndex function

* Update updateCurrentIndex Function

* Persist current tree in navigation/shared conversations v1

Co-authored-by: Kenneth Ramos <kenneth.ramos95@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csusm.edu>

* Removed uncessary comment.

Co-authored-by: Long Dao <hailongdao1017@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csusm.edu>

* Added enhance import and document focus fix.

Co-authored-by: Long Dao <hailongdao1017@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csum.edu>

* Fixed code to have updated formatting and LoadEvent type in page.ts

Co-authored-by: Long Dao <hailongdao1017@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csusm.edu>

* run formatting

* simplify pr

---------

Co-authored-by: Long Dao <hailongdao1017@gmail.com>
Co-authored-by: Eduardo Rocha <rocha092@csusm.edu>
Co-authored-by: Eduardo Rocha <rocha092@csum.edu>
Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet