Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Copy" button styling. Relates to issue 1387 #1403

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

evalstate
Copy link
Contributor

@evalstate evalstate commented Aug 11, 2024

Fix to copy button styling identified in Issue #1387 . Copy button under "ChatMessage" now consistent with other Icons. The component is also used as an icon in "CodeBlock.svelte". The styling for CodeBlock has been kept as it was.

PR recreated due to user error.

@evalstate evalstate changed the title Fix "Copy" button styling. Relates to issue / Fix "Copy" button styling. Relates to issue 1387 Aug 11, 2024
@nsarrazin nsarrazin self-assigned this Aug 12, 2024
Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great in local testing, thanks for the fix!

@nsarrazin nsarrazin merged commit 763cb3b into huggingface:main Aug 12, 2024
3 checks passed
@evalstate
Copy link
Contributor Author

More than welcome - I left the CodeBlock styling as it was - the background for CodeBlocks are always dark, but there is a small change in tone between light/dark modes.

ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
* Fix styling of "Copy to Clipboard" button

* Updated so that Code Block copy button behaves as before.

* fix linting issue.

---------

Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants