Dynamic credential resolution for AWS endpoints #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If AWS credentials are provided, they will continue to be used. With this change, they become optional parameters and the AWS SDK will attempt to use the default resolution chain if they are not provided.
nsarrazin
added
the
models
nsarrazin
reviewed
Aug 23, 2024
ice91
pushed a commit
to ice91/chat-ui
that referenced
this pull request
Oct 30, 2024
* Dynamic credential resolution for AWS endpoints If AWS credentials are provided, they will continue to be used. With this change, they become optional parameters and the AWS SDK will attempt to use the default resolution chain if they are not provided. * cleanup deps * restore optional aws region in endpointAwsParametersSchema --------- Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If AWS credentials are provided, they will continue to be used. With this change, they become optional parameters and the AWS SDK will attempt to use the default resolution chain if they are not provided. More details on the default resolution behavior can be found at https://github.com/zirkelc/aws-sigv4-fetch?tab=readme-ov-file#usage and https://www.npmjs.com/package/@aws-sdk/credential-provider-node
See #926 for more context (and sorry for the delay in opening this PR!), I've been using this patch for a while now and have been able to utilize dynamic and temporary keys instead of static credentials to invoke my sagemaker endpoints