Copy to clipboard Error solve #1487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On google chrome and edge [As i tested on both of them]. The share URL is not copying to clipboard. So, this PR resolves that issue.
|
PR didn't work for me on chrome in local testing 😅 I ended up fixing it here: #1497 Currently deploying to production, let me know if it works there for you otherwise i can take another look |
Your PR worked for me as well. |
|
@nsarrazin Thanks for making it better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On google chrome and edge [As i tested on both of them]. The share URL is not copying to clipboard. So, this PR resolves that issue.