[vertex] Add PDF/plein texts support #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurGoupil
commented
Oct 14, 2024
src/lib/server/endpoints/document.ts
Outdated
There was a problem hiding this comment.
This document processor might be enriched when specific needs will arise in the future
| ], | ||
| preferredMimeType: "image/webp", | ||
| maxSizeInMB: Infinity, | ||
| maxSizeInMB: 20, |
There was a problem hiding this comment.
vertex supports 20mb of inline files
| @@ -213,7 +213,7 @@ | |||
| ...(!$page.data?.assistant && currentModel.tools | |||
| ? activeTools.flatMap((tool: ToolFront) => tool.mimeTypes ?? []) | |||
| : []), | |||
| ...(currentModel.multimodal ? ["image/*"] : []), | |||
| ...(currentModel.multimodal ? currentModel.multimodalAcceptedMimetypes ?? ["image/*"] : []), | |||
There was a problem hiding this comment.
I prefered to allow passing specific mimetypes rather than adding a quite specific option enableDocumentParsing
ArthurGoupil
changed the title
|
Thanks a lot, looks like a great PR! going to take a look 😄 |
nsarrazin
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this issue #1505, adding PDF and plain text support to Vertex.
The basis has also been setup for other endpoints that would support inline documents.
DEMO
Enregistrement.de.l.ecran.2024-10-14.a.18.51.24.mov