-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add you.com integration #514
Conversation
* feat: add types * feat: specify search provider
* feat: add types * feat: specify search provider * add values for ui
[internal] some context in our internal Slack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaved a few comments but LGTM 👍
@sam-h-bean created a PR against your branch sam-h-bean#4 on your fork |
This reverts commit fbfe012.
* `npm run format` * enable search when `YDC_API_KEY` is available * typing nit * enum WebSearchProvider * eslint-disable-next-line no-shadow
merged |
Think this would still need some work to bypass the web scraping since we automatically provide the text snippets. |
* Order desc you.com results by text length * You.com already provides texts from webpages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@nsarrazin could you check the CI error? |
taken care of! |
this is quite cool, we might switch the provider on our main instance hf.co/chat to you! 😁 We should coordinate on some comms if we do make this switch, WDYT? |
Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu>
Love this! ❤️ |
Evaluation of google vs you.com: Google Sheet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good to me! Thanks for the contribution we'll be merging this now.
* add you.com integration * [Feat] Add types (huggingface#1) * feat: add types * feat: specify search provider * [Feat] add return values (huggingface#3) * feat: add types * feat: specify search provider * add values for ui * add idea to gitignore * lint and downgrade * Revert "lint and downgrade" This reverts commit fbfe012. * Updates to you.com integration (huggingface#4) * `npm run format` * enable search when `YDC_API_KEY` is available * typing nit * enum WebSearchProvider * eslint-disable-next-line no-shadow * downgrade * You.com already provides text snippets (huggingface#5) * Order desc you.com results by text length * You.com already provides texts from webpages * add to env * Update .env Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> * Update src/lib/server/websearch/searchWeb.ts --------- Co-authored-by: David Li <david.li3100@gmail.com> Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu>
Add you.com as a search engine option
Before this PR, only Google was used as a search engine. With this PR, the search functionality gets generlized making it possible to choose between Google & You.com
How to make You.com the selected search engine for chat-ui
YDC_API_KEY
(docs.you.com).env.local
file of chat-uiScreenshot of you.com being used as search engine for chat-ui