Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] UI bug "Delete" label #717

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[Fix] UI bug "Delete" label #717

merged 1 commit into from
Jan 22, 2024

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Jan 22, 2024

TLDR:

"Delete" label was staying even though the conversation was deleted

Before

Screen.Recording.2024-01-22.at.10.04.19.AM.mov

After

Screen.Recording.2024-01-22.at.10.03.50.AM.mov

@mishig25 mishig25 requested review from nsarrazin and gary149 January 22, 2024 09:06
Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I was used to it at this point but makes more sense like this 😁

@mishig25 mishig25 merged commit a6e6ee6 into main Jan 22, 2024
3 checks passed
@mishig25 mishig25 deleted the fix/delete_label branch January 22, 2024 09:16
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants