Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON5 for embeddings #719

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Use JSON5 for embeddings #719

merged 1 commit into from
Jan 22, 2024

Conversation

nsarrazin
Copy link
Collaborator

We were parsing with built-in JSON but we use JSON5 everywhere else so just a quickfix here

Should fix #716

@nsarrazin nsarrazin added enhancement New feature or request back This issue is related to the Svelte backend or the DB labels Jan 22, 2024
@nsarrazin nsarrazin requested a review from mishig25 January 22, 2024 11:01
mishig25
mishig25 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@nsarrazin nsarrazin merged commit 6e0b0ea into main Jan 22, 2024
3 checks passed
@nsarrazin nsarrazin deleted the fix/use_json5_for_embeddings branch January 22, 2024 13:20
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
@nsarrazin
Use JSON5 for embeddings (huggingface#719)
65bfb19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishig25 mishig25 mishig25 approved these changes

Assignees
No one assigned
Labels
back This issue is related to the Svelte backend or the DB enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON.parse
2 participants
@nsarrazin @mishig25